Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mower behavior skip path option added #60

Merged
merged 12 commits into from
Oct 27, 2023

Conversation

midevil
Copy link
Contributor

@midevil midevil commented Aug 26, 2023

No description provided.

added skip_path command
added skip_path boolean for skip path command
add skip_path action
modification of skip_path code
moved logic for skip_path
skip path implemented
@midevil midevil marked this pull request as draft September 5, 2023 06:14
@midevil midevil marked this pull request as ready for review September 5, 2023 06:17
.github/workflows/build-image.yaml Show resolved Hide resolved
tags:
- 'v*.*.*'
pull_request:
branches:
- 'main'
- 'startinzone'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thank you

@@ -29,5 +29,5 @@ gen.add("add_fake_obstacle", bool_t, 0, "True to add a fake obstacle to hopefull
gen.add("ignore_gps_errors", bool_t, 0, "True to ignore gps errors. USE ONLY FOR SIMULATION!", False)
gen.add("max_first_point_attempts", int_t, 0, "Maximum attempts to reach the first point of the mow path before trimming", 3, 1, 10)
gen.add("max_first_point_trim_attempts", int_t, 0, "After <max_first_point_attempts> we start to trim the path beginning this often", 3, 1, 10)

gen.add("clear_path_on_start", bool_t, 0, "True to reset current mowing path on start, useful to start in given area", False)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Owner

@ClemensElflein ClemensElflein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

.github/workflows/build-image.yaml Show resolved Hide resolved
tags:
- 'v*.*.*'
pull_request:
branches:
- 'main'
- 'startinzone'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thank you

@@ -29,5 +29,5 @@ gen.add("add_fake_obstacle", bool_t, 0, "True to add a fake obstacle to hopefull
gen.add("ignore_gps_errors", bool_t, 0, "True to ignore gps errors. USE ONLY FOR SIMULATION!", False)
gen.add("max_first_point_attempts", int_t, 0, "Maximum attempts to reach the first point of the mow path before trimming", 3, 1, 10)
gen.add("max_first_point_trim_attempts", int_t, 0, "After <max_first_point_attempts> we start to trim the path beginning this often", 3, 1, 10)

gen.add("clear_path_on_start", bool_t, 0, "True to reset current mowing path on start, useful to start in given area", False)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@ClemensElflein ClemensElflein merged commit f6ddd79 into ClemensElflein:main Oct 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants